New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This avoids a CF allocation on data fetcher in the main case where there is no exception #3235
Conversation
…ere was no exception
@bbakerman what about using a single
|
The error handler returns |
protected <T> CompletableFuture<T> handleFetchingException(ExecutionContext executionContext, | ||
DataFetchingEnvironment environment, | ||
Throwable e) { | ||
protected <T> CompletableFuture<T> handleFetchingException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never used
* | ||
* @throws java.lang.ClassCastException if it's not an Iterable | ||
*/ | ||
protected Iterable<Object> toIterable(Object result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never used
* | ||
* @throws java.lang.ClassCastException if it's not an Iterable | ||
*/ | ||
protected Iterable<Object> toIterable(Object result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically a breaking change BUT a low risk one
No description provided.