19.x Backport PR 3539 #3543
Merged
19.x Backport PR 3539 #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
changed the title
dondonz
changed the title
dondonz
commented
Mar 25, 2024
| byte[] bytes; | ||
| try (InputStream inputStream = resource.openStream()) { | ||
| // In GraphQL Java version 21 and above, this Guava helper is replaced with Java 9's readAllBytes() | ||
| bytes = ByteStreams.toByteArray(inputStream); |
There was a problem hiding this comment.
Fun one: readAllBytes is only in Java 9 onwards so here's the Guava equivalent. We selectively shade in Guava files (e.g. Immutable objects already in use) so we're alright to use Guava here.
bbakerman
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #3539 and bring a number of related files up to date with v21.x, so that we minimise API changes between files connected to ExecutableNormalizedOperationFactory across v19/20/21
Note: introspection node count is 1 less in v19 because the new
@oneOfdirective is only included in v21 onwards