Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graphql-config #828

Closed
edno opened this issue Apr 17, 2023 · 1 comment · Fixed by #885
Closed

Support graphql-config #828

edno opened this issue Apr 17, 2023 · 1 comment · Fixed by #885
Assignees
@edno
Labels
enhancement New feature or request

Comments

@edno
Copy link
Member

edno commented Apr 17, 2023 •
edited

Is your feature request related to a problem? Please describe.
The graphql-config provides an almost standard for GraphQL tools, with a better compliance with schema loading library @graphql-tools/load

Describe the solution you'd like
Deprecate the parameters schema and loaders to be replaced by graphqlConfig as filepath for the GraphQL Config file.

⚠️ TODO: review how schema loaders are supported

Describe alternatives you've considered
n/a

Additional context

Discussion started in #814.

GraphQL config also supports schema stitching.

Handling of documents is not part of the scope. However, as GraphQL config file can be used by several tools this is not a concern.

Default loaders provided by the package:

  • @graphql-tools/graphql-file-loader
  • @graphql-tools/json-file-loader
  • @graphql-tools/url-loader
@edno edno added the enhancement New feature or request label Apr 17, 2023
@edno edno self-assigned this Apr 17, 2023
@edno edno added this to the 1.18.0 milestone Apr 19, 2023
@edno edno removed this from the 1.18.0 milestone May 5, 2023
edno added a commit that referenced this issue Jun 30, 2023
@edno
✨ add support for graphql-config (#828)
27f2111
@edno edno linked a pull request Jun 30, 2023 that will close this issue
✨ add support for graphql-config (#828) #885
Merged
5 tasks
@edno
Copy link
Member Author

edno commented Jun 30, 2023 •
edited

Implementation in PR #885

@edno edno closed this as completed in #885 Jun 30, 2023
edno added a commit that referenced this issue Jun 30, 2023
@edno
✨ add support for graphql-config (#828) (#885)
b3a9f55
@edno edno mentioned this issue Jul 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edno edno

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ add support for graphql-config (#828) graphql-markdown/graphql-markdown
1 participant
@edno