Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add support for generated category index #575

Merged
merged 11 commits into from
Jul 13, 2022
Merged

✨ add support for generated category index #575

merged 11 commits into from
Jul 13, 2022

Conversation

edno
Copy link
Member

@edno edno commented Jul 13, 2022 •
edited

Description

Implements #573 for generated index.

The custom index requires implementing a full sidebar generator. This will be implemented in a separate PR.

Checklist

  • My changes follow the contributing guidelines of this project.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my changes work.
  • New and existing unit tests pass locally with my changes.

@edno edno changed the title ✨ add support for autogenerated index (mvp) ✨ add support for category index Jul 13, 2022
@coveralls
Copy link

coveralls commented Jul 13, 2022 •
edited

Coverage Status

Coverage increased (+0.08%) to 93.699% when pulling d42e0ea on feat/category-support into 5fde83f on main.

@ghost
Copy link

ghost commented Jul 13, 2022 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@edno edno changed the title ✨ add support for category index ✨ add support for autogenerated category index Jul 13, 2022
@edno edno linked an issue Jul 13, 2022 that may be closed by this pull request
Improve support for Category #573
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edno edno added this to the 1.11 milestone Jul 13, 2022
@edno edno marked this pull request as ready for review July 13, 2022 20:41
@edno edno changed the title ✨ add support for autogenerated category index ✨ add support for generated category index Jul 13, 2022
@edno edno merged commit 97001ca into main Jul 13, 2022
@edno edno deleted the feat/category-support branch July 13, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

Improve support for Category
2 participants
@edno @coveralls