Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Docusausus TS support #625

Merged
merged 3 commits into from
Sep 4, 2022
Merged

improve Docusausus TS support #625

merged 3 commits into from
Sep 4, 2022

Conversation

edno
Copy link
Member

@edno edno commented Sep 1, 2022 •
edited
Loading

Description

fixes #619

Screenshot from 2022-09-04 16-11-28

Screenshot from 2022-09-04 16-11-43

Checklist

  • My changes follow the contributing guidelines of this project.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my changes work.
  • New and existing unit tests pass locally with my changes.

@ghost
Copy link

ghost commented Sep 1, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.132% when pulling bf4491d on fix/typescript-support into d0f2bc9 on main.

@edno edno added this to the 1.13.1 milestone Sep 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edno edno marked this pull request as ready for review September 4, 2022 14:13
@edno edno merged commit e772ff3 into main Sep 4, 2022
@edno edno deleted the fix/typescript-support branch September 4, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.

Add JSDoc type annotations for Typescript Docusaurus users
2 participants
@edno @coveralls