Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support documentation categories by different root types #833

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Support documentation categories by different root types #833

merged 3 commits into from
Apr 19, 2023

Conversation

ljiang-ti
Copy link
Contributor

Description

Group schema type to group category mapping to root types (attempted solution). This would cover more use cases described in #831.

Checklist

  • My changes follow the contributing guidelines of this project.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my changes work.
  • New and existing unit tests pass locally with my changes.

@ljiang-ti ljiang-ti requested a review from edno as a code owner April 19, 2023 16:05
@ghost
Copy link

ghost commented Apr 19, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

edno
edno previously approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@edno edno left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

One small comment on one of the unit test, but nothing blocking.

You even updated packages/core/tests/__data__/schema_with_grouping.graphql 🤩

packages/core/tests/unit/group-info.test.js Outdated Show resolved Hide resolved
@edno edno linked an issue Apr 19, 2023 that may be closed by this pull request
Support documentation categories by different root types #831
Closed
@edno edno added this to the 1.17.3 milestone Apr 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

edno
edno approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@edno edno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! I will release this asap in 1.17.3

@edno edno merged commit 6af74db into graphql-markdown:main Apr 19, 2023
21 checks passed
@coveralls
Copy link

Coverage Status

Coverage: 94.701% (-0.04%) from 94.745% when pulling 6cdf02b on ljiang-ti:fix/issue-831 into 6029e67 on graphql-markdown:main.

@coveralls
Copy link

Coverage Status

Coverage: 94.701% (-0.04%) from 94.745% when pulling 4ebce2c on ljiang-ti:fix/issue-831 into 6029e67 on graphql-markdown:main.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage: 94.701% (-0.04%) from 94.745% when pulling 4ebce2c on ljiang-ti:fix/issue-831 into 6029e67 on graphql-markdown:main.

@edno edno mentioned this pull request Apr 20, 2023
Merged
5 tasks
@edno
Copy link
Member

edno commented Apr 20, 2023

@ljiang-ti - Release 1.17.3 is now live.

Big thank you for this first contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edno edno edno approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.

Support documentation categories by different root types
3 participants
@ljiang-ti @coveralls @edno