Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ move group functions to package utils #835

Merged
merged 7 commits into from
Apr 20, 2023
Merged

♻️ move group functions to package utils #835

merged 7 commits into from
Apr 20, 2023

Conversation

edno
Copy link
Member

@edno edno commented Apr 20, 2023 •
edited
Loading

Description

Move group handling functions from core to utils since they are support functions.

Checklist

  • My changes follow the contributing guidelines of this project.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my changes work.
  • New and existing unit tests pass locally with my changes.

@edno edno changed the title Chore/move group utils ♻️ move group functions to package utils Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Warnings
⚠️

This PR modified some Jest snapshot file/s:

  • packages/core/tests/integration/snapshots/generator.spec.js.snap

Generated by 🚫 dangerJS against e41f4fe

@ghost
Copy link

ghost commented Apr 20, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edno edno modified the milestones: 1.18.0, 1.17.3 Apr 20, 2023
@edno edno merged commit 7a605fa into main Apr 20, 2023
@edno edno deleted the chore/move-group-utils branch April 20, 2023 09:42
@edno edno mentioned this pull request Apr 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@edno