Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong fieldName type on subscriptionField (and fix backingTypes.spec.ts) #159

Merged
merged 3 commits into from Jun 19, 2019

Conversation

P4sca1
Copy link
Contributor

@P4sca1 P4sca1 commented Jun 18, 2019

Closes #158

@P4sca1
Copy link
Contributor Author

P4sca1 commented Jun 18, 2019

@tgriesser Seems like the following commit broke the test?
c141ce2#diff-c210621420306561f52c8e2cfaad465d

@P4sca1 P4sca1 changed the title Fix wrong fieldName type on subscriptionField Fix wrong fieldName type on subscriptionField (and fix backingTypes.spec.ts) Jun 18, 2019
@tgriesser tgriesser merged commit b1089a5 into graphql-nexus:develop Jun 19, 2019
@tgriesser
Copy link
Member

Awesome, thanks!

@P4sca1 P4sca1 deleted the patch-1 branch June 19, 2019 10:56
tgriesser added a commit that referenced this pull request Aug 13, 2019
* develop:
  Fix inline functions for custom scalars (#174)
  Fix types in Ghost example
  Fix nexus-prisma doc title and label (#166)
  [RFR] Allow schema construction even with unknown types (#155)
  Add docs for nexus-prisma v2 (#164)
  Fix wrong fieldName type on subscriptionField (and fix backingTypes.spec.ts) (#159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subscriptionField has wrong type for field name
2 participants