Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document subscription type #593

Merged
merged 2 commits into from Nov 2, 2020

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Oct 30, 2020

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #593 into develop will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff            @@
##           develop     #593   +/-   ##
========================================
  Coverage    93.45%   93.45%           
========================================
  Files           39       39           
  Lines         2429     2429           
  Branches       502      502           
========================================
  Hits          2270     2270           
  Misses         159      159           

Copy link
Member

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jasonkuhrt jasonkuhrt merged commit 2de6f89 into develop Nov 2, 2020
@jasonkuhrt jasonkuhrt deleted the chore/doc-subscription-time branch November 2, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Subscriptions?
2 participants