Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to latest #649

Merged
merged 2 commits into from Nov 23, 2020
Merged

deps: update to latest #649

merged 2 commits into from Nov 23, 2020

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Nov 20, 2020

closes #580

Basically we now say they should use TS 4.1. And in the future we'll force that without introducing a breaking change... I guess. 馃槙

It seems pedantic but we could apply a TS 4.1 feature somewhere just to force the upgrade and avoid confusion later. E.g.:

type Foobar = 'hello'
type ForceTS41 = `${Foobar} World`

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #649 (8ceac6b) into develop (481e2c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #649   +/-   ##
========================================
  Coverage    92.75%   92.75%           
========================================
  Files           42       42           
  Lines         2732     2732           
  Branches       624      624           
========================================
  Hits          2534     2534           
  Misses         195      195           
  Partials         3        3           

"iterall": "^1.2.2",
"tslib": "^1.9.3"
"iterall": "^1.3.0",
"tslib": "^2.0.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note https://github.com/microsoft/tslib/releases/tag/2.0.0

Requires TS 3.9+

But should be fine for us here since #580

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier needs to be bumped to 2.2 if you want to use any of the new template string features FYI, not that needs to happen here since we're not using any yet (and should probably hold off unless there's a compelling need).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does tslib need to change to use 4.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does tslib need to change to use 4.1?

Not that I know of, but I figured we should update it as a matter of housekeeping.

@jasonkuhrt jasonkuhrt merged commit 506b61b into develop Nov 23, 2020
@jasonkuhrt jasonkuhrt deleted the deps/update-to-latest branch November 23, 2020 14:27
tgriesser added a commit that referenced this pull request Nov 23, 2020
* develop:
  feat(config): SDL file generation by default in development (#652)
  chore(docs): add atomicOperations setting for prisma plugin (#587)
  deps: update to latest (#649)
  chore: Add release changelog entries to CHANGELOG.md (#656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise minimum required TS version to 4.1
2 participants