New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update to latest #649
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #649 +/- ##
========================================
Coverage 92.75% 92.75%
========================================
Files 42 42
Lines 2732 2732
Branches 624 624
========================================
Hits 2534 2534
Misses 195 195
Partials 3 3 |
"iterall": "^1.2.2", | ||
"tslib": "^1.9.3" | ||
"iterall": "^1.3.0", | ||
"tslib": "^2.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note https://github.com/microsoft/tslib/releases/tag/2.0.0
Requires TS 3.9+
But should be fine for us here since #580
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier needs to be bumped to 2.2 if you want to use any of the new template string features FYI, not that needs to happen here since we're not using any yet (and should probably hold off unless there's a compelling need).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does tslib need to change to use 4.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does tslib need to change to use 4.1?
Not that I know of, but I figured we should update it as a matter of housekeeping.
closes #580
Basically we now say they should use TS 4.1. And in the future we'll force that without introducing a breaking change... I guess. 馃槙
It seems pedantic but we could apply a TS 4.1 feature somewhere just to force the upgrade and avoid confusion later. E.g.: