Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code example #781

Merged
merged 5 commits into from Jan 13, 2021
Merged

docs: fix code example #781

merged 5 commits into from Jan 13, 2021

Conversation

denisborovikov
Copy link
Contributor

@denisborovikov denisborovikov commented Jan 12, 2021

  1. Code and diff tabs code don't match
  2. This is the first appearance of stringArg, it's never used before.
  3. Display SDL code in a tab (same manner as the existing code below)

This is the first appearance of `stringArg`, it's never used before.
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #781 (837904f) into main (cb22957) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          46       46           
  Lines        2930     2930           
  Branches      692      692           
=======================================
  Hits         2748     2748           
  Misses        180      180           
  Partials        2        2           

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jasonkuhrt jasonkuhrt merged commit 55bca2d into graphql-nexus:main Jan 13, 2021
@denisborovikov denisborovikov deleted the patch-2 branch January 13, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants