Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore keepalives before connection_ack in websockets transport #110

Merged
merged 1 commit into from Jul 5, 2020
Merged

Ignore keepalives before connection_ack in websockets transport #110

merged 1 commit into from Jul 5, 2020

Conversation

leszekhanusz
Copy link
Collaborator

This should fix bug #108

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 028145e on leszekhanusz:ignore_keep_alive_before_connection_ack into 29f3fa7 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 028145e on leszekhanusz:ignore_keep_alive_before_connection_ack into 29f3fa7 on graphql-python:master.

@leszekhanusz leszekhanusz mentioned this pull request Jul 4, 2020
Closed
@KingDarBoja KingDarBoja added the type: bug An issue or pull request relating to a bug label Jul 4, 2020
@KingDarBoja KingDarBoja linked an issue Jul 4, 2020 that may be closed by this pull request
Connection ack error when keep alive message arrives first #108
Closed
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jul 4, 2020
@hugbubby
Copy link

hugbubby commented Jul 4, 2020

plz merg

KingDarBoja
KingDarBoja reviewed Jul 5, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is okay, see comment for the single thing I think should be clarified.

gql/transport/websockets.py Show resolved Hide resolved
@KingDarBoja KingDarBoja merged commit b6b7734 into graphql-python:master Jul 5, 2020
leszekhanusz added a commit to leszekhanusz/gql that referenced this pull request Jul 5, 2020
@leszekhanusz
Ignore keepalives before connection_ack in websockets transport (grap…
0f960f6 
…hql-python#110)
@leszekhanusz leszekhanusz deleted the ignore_keep_alive_before_connection_ack branch July 10, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees

@leszekhanusz leszekhanusz

Labels
type: bug An issue or pull request relating to a bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Connection ack error when keep alive message arrives first
4 participants
@leszekhanusz @coveralls @hugbubby @KingDarBoja