type_def argument of Client is now deprecated.

[leszekhanusz]

The Client of gql allows us now to pass a local schema either:

• with the schema argument if the schema is a GraphQLSchema type
• with the type_def argument if the schema is passed as a string

But this is basically the same thing expressed with different types.

I propose to simplify the documentation that the type_def argument becomes deprecated and that the local schema is passed using the schema argument for both types.

To summarize, you should use schema= now instead of previously type_def= in the Client.

The schema argument will accept either:

• a string (previously passed to the type_def argument)
• a GraphQLSchema (like before)

[coveralls]

Coverage remained the same at 100.0% when pulling 0e08621 on leszekhanusz:deprecated_type_def_argument into c0bec62 on graphql-python:master.

[coveralls]

Coverage remained the same at 100.0% when pulling c97647e on leszekhanusz:deprecated_type_def_argument into faadac4 on graphql-python:master.

[KingDarBoja]

I would rather have removed the type_def argument and mark as breaking change for gql v3.

[leszekhanusz]

I would rather have removed the type_def argument and mark as breaking change for gql v3.

We could leave it as deprecated now and remove it once we are at the stable 3.0 ?

[KingDarBoja]

I would rather have removed the type_def argument and mark as breaking change for gql v3.

We could leave it as deprecated now and remove it once we are at the stable 3.0 ?

Well I am okay with that as long as it doesn't stay for more than 2 minor releases after stable 😄