Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo response_headers in httpx transport #407

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

cybniv
Copy link
Contributor

@cybniv cybniv commented Apr 21, 2023

Should be called response_headers for it to work :)

Thanks for this great piece of software ! ❤️

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (df2b206) 100.00% compared to head (8fe81af) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         2384      2384           
=========================================
  Hits          2384      2384           
Impacted Files Coverage Δ
gql/transport/httpx.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@leszekhanusz leszekhanusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks.

@leszekhanusz leszekhanusz changed the title Fix typo Fix typo response_headers in httpx transport Apr 25, 2023
@leszekhanusz leszekhanusz merged commit 8e1c6f1 into graphql-python:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants