Make retry backoff and status codes customizable #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestsHTTPTransport does not allow customization of urllib3's retry method.
In this PR, I added two new parameters to RequestsHTTPTransport for supporting most of the possible customization cases when the RequestsHTTPTransport is used with retries: retry_backoff_factor & retry_status_forcelist. (See urllib3's doc for Retry)
Two notes on compatibility:
RequestsHTTPTransport
without keyed args, this change is backward incompatible since it changes the order of argumentmethod
, but I can refactor to move two new parameters to the place aftermethod
. In that case, the argumentretries
and the new two arguments related to retries will be separated, which is not a huge deal.