Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pass kwargs into RequestsHTTPTransport requests method #45

Closed
wants to merge 2 commits into from

Conversation

cw1427
Copy link

@cw1427 cw1427 commented Feb 19, 2019

We should allow the **kwargs to be passed into the RequestHTTPTransport by the init kwargs. For example, we would like the requests to mark the SSL verify to be false. So it could be easily to be passed. like :

self.transport = RequestsHTTPTransport(url=self.url, auth=HTTPBasicAuth(self.account, self.pwd), use_json=True,
verify=False)

@scjody
Copy link

scjody commented Apr 11, 2019

@syrusakbary Can this be merged? The CI failures appear unrelated to the code being added.

If there's something missing I'm happy to help.

scjody added a commit to plotly/dds-api-docs that referenced this pull request Apr 11, 2019
This uses an unmerged PR: graphql-python/gql#45
I cloned this as https://github.com/plotly/gql so we'll always have access.
@ankeshanand
Copy link

It would be great if this is merged! One use case we have is passing proxies into the requests POST call. The current API prevents that.

@ankeshanand
Copy link

@syrusakbary Any chance this could merged? It seems very self-contained and would enable a lot of use-cases.

@chriddyp
Copy link

We'd love to see this merged. Let us know if there is anything we can do to help. cc'ing the latest committers @Cito @artofhuman

@artofhuman
Copy link
Contributor

I think we need to post patch version before merging new PRs, but now we dont have access to pypy. Maybe we need to release this lib under the new name on pypy. WDYT @Cito ?

@Cito
Copy link
Member

Cito commented Dec 13, 2019

Yes, we're currently stuck because we can't push to PyPI and Syrus needs to hand over maintainer rights. He did this already with most other libraries in graphql-python, but gql was overlooked because at that time nobody seemed to care. Give us some time to contact Syrus and sort this out, he is always very busy. Creating a new name should be the last resort only.

@Cito Cito closed this in #63 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants