Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less generic exceptions #95

Merged
merged 2 commits into from Jun 14, 2020
Merged

Use less generic exceptions #95

merged 2 commits into from Jun 14, 2020

Conversation

leszekhanusz
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented May 26, 2020 •
edited

Coverage Status

Coverage decreased (-0.004%) to 99.213% when pulling bdf7763 on leszekhanusz:specific_exceptions into 6dde12e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 99.208% when pulling b987c37 on leszekhanusz:specific_exceptions into ce13236 on graphql-python:master.

@leszekhanusz leszekhanusz mentioned this pull request May 26, 2020
Closed
@leszekhanusz leszekhanusz changed the title Use more generic exceptions Use less generic exceptions May 26, 2020
stabacco
stabacco approved these changes May 27, 2020
View reviewed changes
Copy link

@stabacco stabacco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick fix.

scripts/gql-cli Show resolved Hide resolved
KingDarBoja
KingDarBoja approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks good to me 🚀

@KingDarBoja KingDarBoja added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jun 14, 2020
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 14, 2020
@leszekhanusz leszekhanusz merged commit a21ff73 into graphql-python:master Jun 14, 2020
@leszekhanusz leszekhanusz deleted the specific_exceptions branch June 28, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stabacco stabacco stabacco approved these changes

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leszekhanusz @coveralls @stabacco @KingDarBoja