Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all errors in TransportQueryError exception #96

Conversation

leszekhanusz
Copy link
Collaborator

  • Add an errors attribute in the TransportQueryError to get all the errors in the exception
  • expose private _execute and _subscribe functions to get ExecutionResult data directly if needed

@coveralls
Copy link

coveralls commented May 30, 2020

Coverage Status

Coverage increased (+0.01%) to 99.225% when pulling a5313e0 on leszekhanusz:feature_return_all_errors_in_transport_query_error_exception into a21ff73 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.224% when pulling 9a22931 on leszekhanusz:feature_return_all_errors_in_transport_query_error_exception into ce13236 on graphql-python:master.

@leszekhanusz
Copy link
Collaborator Author

Note: instead of private _execute and _subscribe functions, we could have public functions with a more explicit name (something like execute_execution_result and subscribe_execution_result but it is a little too much verbose for my taste)

@KingDarBoja KingDarBoja added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: tests Adding missing or correcting existing tests labels Jun 14, 2020
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 14, 2020
@leszekhanusz leszekhanusz self-assigned this Jun 28, 2020
@KingDarBoja KingDarBoja merged commit 87cc5b2 into graphql-python:master Jun 29, 2020
leszekhanusz added a commit to leszekhanusz/gql that referenced this pull request Jul 5, 2020
@leszekhanusz leszekhanusz deleted the feature_return_all_errors_in_transport_query_error_exception branch July 10, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: tests Adding missing or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants