Skip to content

Commit

Permalink
Fix schema dump on windows (#1123)
Browse files Browse the repository at this point in the history
Without explicitly setting the encoding to "utf-8" I get the following error on windows (python 3.9)

```
  File "D:\env\lib\site-packages\graphene_django\management\commands\graphql_schema.py", line 115, in handle
    self.get_schema(schema, out, indent)
  File "D:\env\lib\site-packages\graphene_django\management\commands\graphql_schema.py", line 72, in get_schema
    self.save_graphql_file(out, schema)                                                                                   
  File "D:\env\lib\site-packages\graphene_django\management\commands\graphql_schema.py", line 59, in save_graphql_file      
    outfile.write(print_schema(schema.graphql_schema))                                                                    
  File "C:\Users\u\AppData\Local\Programs\Python\Python39\lib\encodings\cp1252.py", line 19, in encode 
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
```
  • Loading branch information
andrei-datcu committed Feb 23, 2021
1 parent 007768b commit 5ce4553
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion graphene_django/management/commands/graphql_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def save_json_file(self, out, schema_dict, indent):
json.dump(schema_dict, outfile, indent=indent, sort_keys=True)

def save_graphql_file(self, out, schema):
with open(out, "w") as outfile:
with open(out, "w", encoding="utf-8") as outfile:
outfile.write(print_schema(schema.graphql_schema))

def get_schema(self, schema, out, indent):
Expand Down

0 comments on commit 5ce4553

Please sign in to comment.