Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backward Relay pagination (#1009) #1010

Closed
wants to merge 1 commit into from
Closed

Fix backward Relay pagination (#1009) #1010

wants to merge 1 commit into from

Conversation

lucas-bremond
Copy link
Contributor

This PR is an attempt to fix the backward pagination issue #1009.

@lucas-bremond
Copy link
Contributor Author

@syrusakbary Any chance to get a review on that? :)

zbyte64
zbyte64 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct but a unit test would be nice

@tcleonard tcleonard mentioned this pull request Oct 16, 2020
Merged
@tcleonard
Copy link
Collaborator

@zbyte64 I have added a new pull request (#1046) which adds unit tests

@tcleonard tcleonard mentioned this pull request Nov 20, 2020
Merged
@zbyte64 zbyte64 closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucas-bremond @tcleonard @zbyte64