Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter for django 3.1 JSONField #1017

Merged
merged 2 commits into from Aug 7, 2020

Conversation

nikolaik
Copy link
Contributor

@nikolaik nikolaik commented Aug 2, 2020

Should probably wait until django 3.1 is released and possible to add to the test matrix.

Also found #303 thread suggesting people have a use case for converting JSONField (django 3.1, django_mysql and postgres ones) to GenericScalar. I'm not sure what is most common.

@jkimbo
Copy link
Member

jkimbo commented Aug 5, 2020

Thanks @nikolaik . Django v3.1 has been released now so could you add it to the test matrix?

@nikolaik
Copy link
Contributor Author

nikolaik commented Aug 5, 2020

Thanks @nikolaik . Django v3.1 has been released now so could you add it to the test matrix?

yaz, done

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @nikolaik

@jkimbo jkimbo merged commit 67a0492 into graphql-python:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants