Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing doc #1024

Merged
merged 1 commit into from Aug 26, 2020
Merged

Fix testing doc #1024

merged 1 commit into from Aug 26, 2020

Conversation

artofhuman
Copy link
Contributor

No description provided.

@artofhuman
Copy link
Contributor Author

@jkimbo Hi, sorry for pr without description. As you can see we define pytest fixture and use the new fixture in the test case as an argument. But call the wrong fixture in test body. Can we merge this?

zbyte64
zbyte64 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkimbo jkimbo merged commit 88eefb0 into graphql-python:master Aug 26, 2020
@jkimbo
Copy link
Member

jkimbo commented Aug 26, 2020

Thanks @artofhuman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

@jkimbo jkimbo jkimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artofhuman @jkimbo @zbyte64