Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken UT due to pytest import error #1368

Merged
merged 1 commit into from Nov 14, 2022
Merged

Fix broken UT due to pytest import error #1368

merged 1 commit into from Nov 14, 2022

Conversation

yuekui
Copy link
Contributor

@yuekui yuekui commented Nov 10, 2022 •
edited

This was referenced Nov 10, 2022
Merged
Merged
@ulgens
Copy link
Collaborator

ulgens commented Nov 10, 2022

@yuekui Thanks a lot 🌷

@ulgens
Copy link
Collaborator

ulgens commented Nov 10, 2022

ping @firaskafri

@ulgens
Copy link
Collaborator

ulgens commented Nov 11, 2022 •
edited

@yuekui Let's wait a couple of days for additional approval. If it doesn't come until Monday, I'll merge it.

@ulgens ulgens merged commit 86c5309 into graphql-python:main Nov 14, 2022
kiendang pushed a commit to santiagoaguiar/graphene-django that referenced this pull request May 26, 2023
@yuekui @kiendang
Fix broken UT due to pytest import error (graphql-python#1368)
da9cd77
firaskafri pushed a commit that referenced this pull request May 26, 2023
@santiagoaguiar @yuekui
@jaw9c @kiendang
Backport Django 4.1 compatibility fixes to v2 (#1413)
7c780a9 
* handle deprecation warning for requires_system_checks

Removed in django 4.1.

* Fix broken UT due to pytest import error (#1368)

* import error resolved?

* Fix tests

* Remove Python 3.6

* django 4.1 requires python>=3.10

* Django 4.1 does support python 3.8 to 3.11

* Add Django 4.1 to tox

---------

Co-authored-by: Yuekui <yuekui@users.noreply.github.com>
Co-authored-by: Josh Warwick <josh.warwick15@gmail.com>
Co-authored-by: Kien Dang <mail@kien.ai>
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
@yuekui @superlevure
Fix broken UT due to pytest import error (graphql-python#1368)
6f74b59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuekui @ulgens