-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Python 3.11 and Django 4.2 in v2 #1456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wongcht! Just a few suggestions.
django42 <43 Co-authored-by: Kien Dang <kiend@pm.me>
master to main Co-authored-by: Kien Dang <kiend@pm.me>
Co-authored-by: wongcht <wongchunhong.work@gmail.com>
@firaskafri @kiendang Hey guys, I apologize for commenting on a closed MR, but will this be part of a v2 release soon? We're in the middle of attempting to upgrade to Django 4.2, but currently cannot because the current graphene-django v2 release doesn't support Django 4.2. We've tried using graphene-django v3, but ran into issues because some of our resolvers are async and it looks like graphene-django v3 doesn't support async resolvers yet. |
@cpd67 This PR only added tests for Django 4.2 to CI and made no changes to the code. You could already use the current
We currently have a PR open for adding async to v3 #1394 which we are considering releasing as an experimental feature soon (see this discussion). Are you interested in trying that out? Would help us a lot. You can try the PR right now with pip install git+https://github.com/jaw9c/graphene-django.git@support-async |
@cpd67 I see. Yup I'm aware of your PR, just didn't recognize it was you haha.
Thank you so much! |
v2.16.0 supports Django 4.1, actually it also passes the tests in Python 3.11 and Django 4.2.
Suggest changing the latest supported version to cover Django 4.2 LTS, while currently 4.1 EOL in 3 months (2023-12-1).