Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Django 4.1 (EOL) and add Django 5.0 to CI #1483

Merged
merged 1 commit into from Dec 14, 2023
Merged

Remove Django 4.1 (EOL) and add Django 5.0 to CI #1483

merged 1 commit into from Dec 14, 2023

Conversation

kiendang
Copy link
Collaborator

@kiendang kiendang commented Dec 8, 2023 •
edited

sjdemartini
sjdemartini approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice to see 5.0 passed all tests without any changes 😄

@kiendang
Copy link
Collaborator Author

kiendang commented Dec 8, 2023

Looks great! Nice to see 5.0 passed all tests without any changes 😄

Yup. Turned out that 1 failed test was with djangomain and we don't need to worry about that until future releases.

@firaskafri firaskafri merged commit db2d40e into main Dec 14, 2023
12 checks passed
@firaskafri firaskafri deleted the django-5 branch December 14, 2023 08:20
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jan 30, 2024
@kiendang @superlevure
Remove Django 4.1 (EOL) and add Django 5.0 to CI (graphql-python#1483)
8e6d0a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjdemartini sjdemartini sjdemartini approved these changes

@ulgens ulgens Awaiting requested review from ulgens

@firaskafri firaskafri Awaiting requested review from firaskafri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiendang @sjdemartini @firaskafri