Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importing error for GraphQLTestCase #631

Merged
merged 1 commit into from May 13, 2019
Merged

Fix importing error for GraphQLTestCase #631

merged 1 commit into from May 13, 2019

Conversation

phalt
Copy link
Contributor

@phalt phalt commented May 8, 2019

As mentioned in #628 you cannot import GraphQLTestCase, this is because the directory is excluded when published.

The best solution is to move this under utils and change the import. It's broken anyway.

Fixes #628

@phalt phalt added this to In progress in Improvements May 8, 2019
@phalt phalt moved this from In progress to In review in Improvements May 8, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@phalt
Copy link
Contributor Author

phalt commented May 9, 2019

Going to ignore the coveralls on this as we're just shuffling around some code.

GitRon
GitRon approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@phalt phalt merged commit e26a9f2 into master May 13, 2019
Improvements automation moved this from In review to Done May 13, 2019
@phalt phalt deleted the fix-628 branch May 13, 2019 17:12
@phalt phalt mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanlonden mvanlonden mvanlonden approved these changes

@GitRon GitRon GitRon approved these changes

@dopeboy dopeboy Awaiting requested review from dopeboy

@ekampf ekampf Awaiting requested review from ekampf

@patrick91 patrick91 Awaiting requested review from patrick91

Assignees
No one assigned
Labels
None yet
Projects
Improvements
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import graphene_django.tests.base_test.GraphQLTestCase
4 participants
@phalt @coveralls @mvanlonden @GitRon