Stop enforcing csrf checks in GraphQLTestCase #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbyte64
approved these changes
Jun 7, 2019
|
I have actually developed quite a bit on my copy paste version of this test case, was thinking of contributing back a lot of my changes, should I just make this PR bigger or do you think I should create a new one? |
jkimbo
approved these changes
Jun 9, 2019
|
@emilgoldsmith could you create a new PR with any further improvements to the test class? |
|
@jkimbo will do! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the purpose of that argument to the class instantiation was, maybe it was an artifact from when a wrapper class was called around the Client? But it acts as the
enforce_csrf_checksargument which was botching up my tests (I copy pasted the class into my own project until you publish 2.3.0)