Allow for easier template overrides in graphiql #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jonathan Kim <jkimbo@gmail.com>
|
@jkimbo no problem with that at all :) |
jkimbo
approved these changes
Jan 30, 2020
|
Thanks @jkimbo! Sorry I forgot to update the CSS when copying changes from my overrides! |
|
No worries! Thanks for the contribution anyway @benhowes |
zbyte64
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: I use https://pypi.org/project/django-impersonate/ to allow testing my API as various users, and it's always handy to have a header which reminds you who you're impersonating.
By making graphiql populate a div rather than body, it's easier to override the template with additional content. Currently graphiql replaces all the content in
bodymeaning any other content you add is also removed.