Detect format from output file path #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbyte64
requested changes
Feb 4, 2020
There was a problem hiding this comment.
We have two methods on the command: save_json_file & save_graphql_file ; We are testing the save_json_file method but dropping coverage for save_graphql_file.
We should duplicate the test test_generate_file_on_call_graphql_schema to test the original functionality.
jkimbo
force-pushed
the
add-format-option-manage-command
branch
from
25d2bd5
to
9fc9bbe
Compare
|
@zbyte64 PR ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output filepath has a .graphql extension then export the schema in the graphql format.