Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable system checks for graphql_schema management command #939

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Disable system checks for graphql_schema management command #939

merged 1 commit into from
Apr 19, 2020

Conversation

millar
Copy link
Contributor

@millar millar commented Apr 19, 2020

I find myself generating the schema as part of CI regularly (to avoid having to check a generated file into source control) but some pipelines don't have access to a database and the system checks will always fail as a result.

To combat this I propose system checks are disabled for the command.

@millar millar changed the title Disable system checks for generate_schema command Disable system checks for graphql_schema command Apr 19, 2020
@millar millar changed the title Disable system checks for graphql_schema command Disable system checks for graphql_schema management command Apr 19, 2020
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't realise you could do this, thanks!

@jkimbo jkimbo merged commit 23b6419 into graphql-python:master Apr 19, 2020
@millar millar deleted the patch-1 branch April 29, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants