Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if fields or exclude are not defined on DjangoObjectType #981

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Warn if fields or exclude are not defined on DjangoObjectType #981

merged 5 commits into from
Jun 11, 2020

Commits on Jun 7, 2020

  1. Warn when DjangoObjectType has neither fields nor exclude option

    @radekwlsk
    radekwlsk committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    30306e8 View commit details
    Browse the repository at this point in the history

  2. Add explicit fields = "__all__" to mute warnings in tests

    @radekwlsk
    radekwlsk committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    64c2371 View commit details
    Browse the repository at this point in the history

  3. Add explicit fields = "__all__" in examples as it will be required soon

    @radekwlsk
    radekwlsk committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    d478275 View commit details
    Browse the repository at this point in the history

  4. Update docs to take new warning into account 

    * all examples have fields or exclude set
* mention that if neither fields nor exclude is used, warning will be raised
    @radekwlsk
    radekwlsk committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    3d497ea View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Bump PendingDeprecationWarning to DeprecationWarning 

    * as it is a major release 3, start right away from DeprecationWarning for ObjectTypes missing fields or exclude option
* updated docs information to be more forbidding
    @radekwlsk
    radekwlsk committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    8054803 View commit details
    Browse the repository at this point in the history