This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Breaking change: ndb KeyProperties should be externalised as Global IDs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 3dfa734 on feature/fix_key_property_behavior into * on master*. |
|
Changes Unknown when pulling 05e87d4 on feature/fix_key_property_behavior into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never externalise internal NDB key values. It doesn't make sense.
GraphQL Nodes IDs are in a global_id format (a base64 encoded :).
It only makes sense that model properties that expose ids of other objects use the same format.
Otherwise the APIs consumer will have to know when to convert from global_id to key and the opposite.