Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support List of GenericReferenceField #83

Closed
wants to merge 6 commits into from
Closed

Support List of GenericReferenceField #83

wants to merge 6 commits into from

Conversation

arunsureshkumar
Copy link
Collaborator

List of GenericReferenceField support is added.

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 264

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_mongo/converter.py 3 4 75.0%
Totals Coverage Status
Change from base Build 263: -0.2%
Covered Lines: 401
Relevant Lines: 415
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 264

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_mongo/converter.py 3 4 75.0%
Totals Coverage Status
Change from base Build 263: -0.2%
Covered Lines: 401
Relevant Lines: 415
💛 - Coveralls

@abawchen
Copy link
Collaborator

@arunsureshkumar : 👍

Would you please add corresponding test cases? At least In test_converter, test_query and test_relay_query.

Arun S Kumar added 4 commits April 24, 2019 15:54
Support List of GenericReferenceField for MongoEngineConnectionField
2174cd1
Relative module imported
61515e3
Support Mongoengine queryset filters using argument
27bc3a1 
Example:

class Employee(MongoengineObjectType):
    class Meta:
        model = EmployeeModel
        interfaces = (Node,)
        filter_fields = {
            'name': ['exact', 'icontains', 'istartswith']
        }
Support Mongoengine queryset filters using argument
f035772 
Example:

class Employee(MongoengineObjectType):
    class Meta:
        model = EmployeeModel
        interfaces = (Node,)
        filter_fields = {
            'name': ['exact', 'icontains', 'istartswith']
        }
@theoribeiro theoribeiro mentioned this pull request Feb 19, 2020
Closed
@abawchen abawchen force-pushed the feat-list-generic-reference-field branch from 4e8bc36 to 32d8b99 Compare February 24, 2020 09:18
@abawchen
Copy link
Collaborator

@arunsureshkumar
Thanks for initiation, and I have finished in #130

@abawchen abawchen closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arunsureshkumar @coveralls @abawchen