Fix example to work with Pydantic V2, add test for examples #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic v2. Add a main() function so that this is easier to test
dantheman39
commented
Feb 1, 2024
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "graphene_pydantic" | |||
| version = "0.6.0" | |||
| version = "0.6.1" | |||
There was a problem hiding this comment.
@necaris any opinions on the version bump being in the same or separate PR? Happy to comply.
necaris
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
examples/departments.pyto comply with changes in how Pydantic handles Optional and null fields.Details
One thing we missed in the review of the PR to add support for pydantic v2: #94, is that the example no longer works and errors out.
This is due to a breaking change in the behavior of Pydantic V2 in regards to optional fields. See this section of the v1 to v2 migration guide, and this long github issue for more discussion on their treatment of optional / nullable fields: pydantic/pydantic#1223