Don't suppress SQLAlchemy errors when mapping classes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorbrinton
changed the title
|
is this blocked? |
|
Nope, everything should be good to go! I just rebased on master to make sure it's up to date with the latest changes as well. |
|
I implemented these changes in a local virtualenv to test an error I was getting. I can confirm that these changes DO indeed fix the problem. |
|
Hi guys, I got this error today. We have any problem to increase these changes on master? |
Nabellaleen
previously requested changes
Mar 18, 2019
These changes modify graphene-sqlalchemy to not suppress errors coming from SQLAlchemy when attempting to map classes. Previously this made the debugging experience difficult, since issues with SQLAlchemy models would produce an unclear error message from graphene-sqlalchemy. With these changes, the SQLAlchemy error is propagated to the end-user, making it possible for them to easily correct the true issue.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 96.92% 96.95% +0.02%
==========================================
Files 9 9
Lines 618 623 +5
==========================================
+ Hits 599 604 +5
Misses 19 19
Continue to review full report at Codecov.
|
erikwrede
approved these changes
Apr 28, 2022
erikwrede
dismissed
Nabellaleen’s stale review
Requested Changes have been implemented
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many SQLAlchemy model definition errors are hidden the way we check if valid models have been provided. This PR allows SQLAlchemy model definition errors to propagate at model check time, and adds a test to confirm that errors are correctly propagated.
Fixes #121