Skip to content

Commit

Permalink
Prevent requirement breaking changes
Browse files Browse the repository at this point in the history
I have a project still in 1.2.0 thats has been broken in my last release since it used `'graphql-core>=1.0.1'` in the `install_requires`. Since `graphql-core` has released version 2.0 with breaking changes and there was no instruction to maintain version 1, it was included as a dependency. This prevents this situation for the future.
  • Loading branch information
lucasrcosta committed Oct 26, 2017
1 parent 34d03a7 commit 71177fe
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ def run_tests(self):
packages=find_packages(exclude=['tests', 'tests.*']),

install_requires=[
'six>=1.10.0',
'graphql-core>=2.0',
'graphql-relay>=0.4.5',
'promise>=2.1',
'six>=1.10.0,<2',
'graphql-core>=2.0,<3',
'graphql-relay>=0.4.5,<1',
'promise>=2.1,<3',
],
tests_require=tests_require,
extras_require={
Expand Down

0 comments on commit 71177fe

Please sign in to comment.