Use default_resolver to resolve values when using the source at… (#1155)

graphql-python · Mar 16, 2020 · cb3bfe0 · cb3bfe0
1 parent 6f2863e
commit cb3bfe0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/graphene/types/field.py b/graphene/types/field.py
@@ -4,6 +4,7 @@
 
 from .argument import Argument, to_arguments
 from .mountedtype import MountedType
+from .resolver import default_resolver
 from .structures import NonNull
 from .unmountedtype import UnmountedType
 from .utils import get_type
@@ -12,7 +13,7 @@
 
 
 def source_resolver(source, root, info, **args):
-    resolved = getattr(root, source, None)
+    resolved = default_resolver(source, None, root, info, **args)
     if inspect.isfunction(resolved) or inspect.ismethod(resolved):
         return resolved()
     return resolved

diff --git a/graphene/types/tests/test_field.py b/graphene/types/tests/test_field.py
@@ -66,6 +66,13 @@ def test_field_source():
     assert field.resolver(MyInstance(), None) == MyInstance.value
 
 
+def test_field_source_dict_or_attr():
+    MyType = object()
+    field = Field(MyType, source="value")
+    assert field.resolver(MyInstance(), None) == MyInstance.value
+    assert field.resolver({"value": MyInstance.value}, None) == MyInstance.value
+
+
 def test_field_with_lazy_type():
     MyType = object()
     field = Field(lambda: MyType)