-
Notifications
You must be signed in to change notification settings - Fork 819
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add UnforgivingExecutionContext (#1255)
- Loading branch information
1 parent
a53b782
commit e24ac54
Showing
2 changed files
with
215 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e24ac54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlecRosenbaum the tests for
UnforgivingExecutionContext
are failing. I am on a windows 11 but that shouldn't affect anything. The problem is withtest_unexpected_error
, I guess. No exceptions are raised by it.edit: I think I've figured out why. Once the schema executes the query, the errors have propagated to the
errors
array in the schema, although an exception is not raised. If this is the intended behaviour, we need to just check if the error exists in theerrors
array, rather than checking if an exception is raised.e24ac54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe some things changed in graphql core around error handling since this was merged. We haven't upgraded graphql core versions yet in our project where this is used, so I haven't had a chance to revisit this yet.
#1255 (comment)