Allow class methods to be used as a field source

graphql-python · Jan 27, 2017 · f728542 · f728542
1 parent 02eb685
commit f728542
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/graphene/types/field.py b/graphene/types/field.py
@@ -13,7 +13,7 @@
 
 def source_resolver(source, root, args, context, info):
     resolved = getattr(root, source, None)
-    if inspect.isfunction(resolved):
+    if inspect.isfunction(resolved) or inspect.ismethod(resolved):
         return resolved()
     return resolved
 

diff --git a/graphene/types/tests/test_field.py b/graphene/types/tests/test_field.py
@@ -10,6 +10,9 @@ class MyInstance(object):
     value = 'value'
     value_func = staticmethod(lambda: 'value_func')
 
+    def value_method(self):
+        return 'value_method'
+
 
 def test_field_basic():
     MyType = object()
@@ -76,6 +79,12 @@ def test_field_source_func():
     assert field.resolver(MyInstance(), {}, None, None) == MyInstance.value_func()
 
 
+def test_field_source_method():
+    MyType = object()
+    field = Field(MyType, source='value_method')
+    assert field.resolver(MyInstance(), {}, None, None) == MyInstance().value_method()
+
+
 def test_field_source_as_argument():
     MyType = object()
     field = Field(MyType, source=String())