Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unidecode to handle unicode characters in constant names #1080

Merged
merged 3 commits into from Feb 8, 2020
Merged

Use unidecode to handle unicode characters in constant names #1080

merged 3 commits into from Feb 8, 2020

Conversation

henrythor
Copy link
Contributor

This fixes #1079

@henrythor
Copy link
Contributor Author

I have no idea why the snapshots are failing in pytest, seems unlikely they're affected by my patch :/

@stale
Copy link

stale bot commented Jan 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 2, 2020
@stale stale bot closed this Jan 16, 2020
@jkimbo
Copy link
Member

jkimbo commented Jan 20, 2020

This is still an issue.

@jkimbo jkimbo reopened this Jan 20, 2020
@stale stale bot removed the wontfix label Jan 20, 2020
@jkimbo
Copy link
Member

jkimbo commented Feb 8, 2020

@henrythor thanks the PR. I've rebased your changes on top of master so that the tests pass (you were right the tests were failing for unrelated reasons).

@ekampf ekampf merged commit 9a19447 into graphql-python:master Feb 8, 2020
@ekampf ekampf mentioned this pull request Feb 8, 2020
Closed
@AlecRosenbaum AlecRosenbaum mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekampf ekampf ekampf approved these changes

@jkimbo jkimbo jkimbo approved these changes

@dan98765 dan98765 Awaiting requested review from dan98765

@ProjectCheshire ProjectCheshire Awaiting requested review from ProjectCheshire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_const doesn't support unicode
3 participants
@henrythor @jkimbo @ekampf