Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default value for argument should be Undefined (Issue #1394) #1412

Merged
merged 1 commit into from Apr 7, 2022
Merged

fix: default value for argument should be Undefined (Issue #1394) #1412

merged 1 commit into from Apr 7, 2022

Conversation

tcleonard
Copy link
Collaborator

@tcleonard tcleonard commented Mar 20, 2022 •
edited

@tcleonard tcleonard mentioned this pull request Mar 20, 2022
Merged
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
fix: test for graphene PR graphql-python/graphene#1412
e969b01
This was referenced Mar 20, 2022
Merged
Merged
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
fix: test for graphene PR graphql-python/graphene#1412
48942be
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
fix: test for graphene PR graphql-python/graphene#1412
9b3a117
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
fix: test for graphene PR graphql-python/graphene#1412
9b0af18
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
fix: test for graphene PR graphql-python/graphene#1412
ca55529
@stabacco
Copy link

A similar fix was provided in #1399 which has been sitting there for a long time unfortunately. Not sure who's supposed to have a look at these but it'd be great if someone could.
This issue is currently holding us back from being able to upgrade all our gql stack.

jkimbo
jkimbo approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkimbo jkimbo merged commit 03277a5 into graphql-python:master Apr 7, 2022
@stabacco stabacco mentioned this pull request Apr 10, 2022
Closed
@mabdinur mabdinur mentioned this pull request May 5, 2022
Merged
4 tasks
@tcleonard tcleonard deleted the issue-#1394_fix-required branch June 20, 2022 13:39
@erikwrede erikwrede mentioned this pull request Aug 27, 2022
Closed
firaskafri pushed a commit to graphql-python/graphene-django that referenced this pull request Sep 23, 2022
@tcleonard
fix: unit test for graphene pr#1412 (#1315)
5d81ba0 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
VV-YY added a commit to VV-YY/graphene-django that referenced this pull request Jan 18, 2023
@VV-YY
fix: unit test for graphene pr#1412 (#1315)
ef579d6 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
paxaxel223 added a commit to paxaxel223/graphe-django that referenced this pull request Apr 25, 2023
@paxaxel223
fix: unit test for graphene pr#1412 (#1315)
7adc570 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
spartacus0816 pushed a commit to spartacus0816/django_dev that referenced this pull request May 22, 2023
fix: unit test for graphene pr#1412 (#1315)
55af0b2 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
azuredevil0818 pushed a commit to azuredevil0818/graphene-django that referenced this pull request Jul 4, 2023
fix: unit test for graphene pr#1412 (#1315)
5f17c31 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
DevStar1016 added a commit to DevStar1016/graphine-django that referenced this pull request Sep 11, 2023
@DevStar1016
fix: unit test for graphene pr#1412 (#1315)
9be823d 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
will9288 added a commit to will9288/graphene-django that referenced this pull request May 5, 2024
@will9288
fix: unit test for graphene pr#1412 (#1315)
774886f 
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcleonard @stabacco @jkimbo