Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default enum description to "An enumeration." #1502

Merged
merged 5 commits into from May 25, 2023

Conversation

firaskafri
Copy link
Contributor

@firaskafri firaskafri commented Apr 11, 2023

Default enum description to "An enumeration." string as opposed to trying to read enum.__doc__ as it appears to be not set to default enum class doc in python 3.11

default to this string, which is used in many tests, is causing
graphene/types/enum.py Outdated Show resolved Hide resolved
@erikwrede
Copy link
Member

Thanks for the PR @firaskafri 🙂
Can we add one or two tests for this that check the prioritization (Description over enum.doc over "An Enumeration")? 🙂

@firaskafri
Copy link
Contributor Author

Thanks for the PR @firaskafri 🙂 Can we add one or two tests for this that check the prioritization (Description over enum.doc over "An Enumeration")? 🙂

Hi @erikwrede !

Just added two tests to address these cases!

erikwrede
erikwrede previously approved these changes May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (57cbef6) 96.00% compared to head (6eaef66) 96.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          51       51           
  Lines        1750     1750           
=======================================
  Hits         1680     1680           
  Misses         70       70           
Impacted Files Coverage Δ
graphene/types/enum.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erikwrede erikwrede merged commit 8ede21e into graphql-python:master May 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants