Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add option for strict connection types #1504

Merged
merged 5 commits into from Jul 26, 2023
Merged

types: add option for strict connection types #1504

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3943353
types: add option for strict connection types
shrouxm May 4, 2023
692e985
chore: appease linter
shrouxm May 18, 2023
cf29f5d
chore: appease linter
shrouxm Jun 8, 2023
4077084
test: add test
shrouxm Jun 8, 2023
035f19c
Merge branch 'master' into master
erikwrede Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions graphene/relay/connection.py
View file
Open in desktop
Expand Up @@ -13,12 +13,18 @@


def get_edge_class(
connection_class: Type["Connection"], _node: Type[AbstractNode], base_name: str
connection_class: Type["Connection"],
_node: Type[AbstractNode],
base_name: str,
strict_types: bool = False,
):
edge_class = getattr(connection_class, "Edge", None)

class EdgeBase:
node = Field(_node, description="The item at the end of the edge")
node = Field(
NonNull(_node) if strict_types else _node,
description="The item at the end of the edge"
)
cursor = String(required=True, description="A cursor for use in pagination")

class EdgeMeta:
Expand Down Expand Up @@ -83,7 +89,9 @@ class Meta:
abstract = True

@classmethod
def __init_subclass_with_meta__(cls, node=None, name=None, _meta=None, **options):
def __init_subclass_with_meta__(
cls, node=None, name=None, strict_types=False, _meta=None, **options
):
if not _meta:
_meta = ConnectionOptions(cls)
assert node, f"You have to provide a node in {cls.__name__}.Meta"
Expand Down Expand Up @@ -111,10 +119,10 @@ def __init_subclass_with_meta__(cls, node=None, name=None, _meta=None, **options
)

if "edges" not in _meta.fields:
edge_class = get_edge_class(cls, node, base_name) # type: ignore
edge_class = get_edge_class(cls, node, base_name, strict_types) # type: ignore
cls.Edge = edge_class
_meta.fields["edges"] = Field(
NonNull(List(edge_class)),
NonNull(List(NonNull(edge_class) if strict_types else edge_class)),
description="Contains the nodes in this connection.",
)

Expand Down