Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphiql and its dependencies to the latest version on jsdelivr #3

Merged
merged 1 commit into from Jun 30, 2017

Conversation

akand074
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 96.386% when pulling 35db2e0 on akand074:update_graphiql into 3ccd939 on graphql-python:master.

@akand074
Copy link
Contributor Author

@syrusakbary I updated the versions to the latest available on jsdelivr, I wanted to bump up to 0.11.2 but it's not available on jsdelivr (other CDNs did).

I also noticed mako's template is identical to the render_graphiql file so I was going to share between the two files but looks like mako.py isn't used at all yet, so perhaps a change for later.

I did notice you can provide your own render_graphiql function which I'll likely use to keep my own hosted copy but good to keep this up to date. I'll make another PR when jsdelivr has the latest version unless you know how to get an update up.

@syrusakbary syrusakbary merged commit 342f08b into graphql-python:master Jun 30, 2017
@jimaek
Copy link

jimaek commented Jun 30, 2017

I just wanted to let you know that jsDelivr can pull files directly from npm and always have the latest versions.

http://cdn.jsdelivr.net/npm/graphiql/
http://cdn.jsdelivr.net/npm/graphiql@0.11.2/graphiql.min.js

@akand074 akand074 deleted the update_graphiql branch June 30, 2017 15:03
@akand074
Copy link
Contributor Author

Ah thanks @jimaek I saw that but for whatever reason I couldn't get it to build properly 😅 maybe will switch to use the NPM-based one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants