Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: websocket connection in subscriptions example #583

Merged
merged 1 commit into from
Mar 25, 2020
Merged

fix: websocket connection in subscriptions example #583

merged 1 commit into from
Mar 25, 2020

Conversation

spacemeowx2
Copy link
Contributor

Added Sec-WebSocket-Protocol header to avoid clients refusing connections.

@spacemeowx2 spacemeowx2 mentioned this pull request Mar 23, 2020
Open
LegNeato
LegNeato requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🍻 ! Can you add a TODO and an issue pointing at the warp issue in case they add a better way in the future?

@LegNeato LegNeato merged commit 3b465cb into graphql-rust:master Mar 25, 2020
@LegNeato
Copy link
Member

Thanks again!

@davidgomesdev davidgomesdev mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spacemeowx2 @LegNeato