Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts file is not installed from npm. #54

Closed
ovrmrw opened this issue Oct 26, 2016 · 5 comments
Closed

index.d.ts file is not installed from npm. #54

ovrmrw opened this issue Oct 26, 2016 · 5 comments

Comments

@ovrmrw
Copy link

ovrmrw commented Oct 26, 2016

Even though there is a typed file (./src/index.d.ts), it is not installed via npm install dataloader command.

@Knaackee
Copy link

Any news? I cant find the type definition in the package.

@iamricard
Copy link

iamricard commented Nov 18, 2016

Same for index.js.flow! Maybe an issue with gitignore? npm uses
it if .npmignore is not present.

@JacobSoderblom
Copy link

JacobSoderblom commented Nov 25, 2016

One way to solve this is to make an PR to DefinitelyTyped and add the type definition. In that way we will be able to install the type definition through npm install @types/dataloader.

#48 will solve this.

@blakeembrey
Copy link
Contributor

Actually, the current definition in this module is incorrect. It needs #51 first.

@leebyron
Copy link
Contributor

This is because a new release wasn't published after typings were added. I'll get a new release out pronto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants