Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphiql): duplicate query history key issue, fixes #988 #1035

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

acao
Copy link
Member

@acao acao commented Dec 1, 2019

fixes #988.
needs tests

@acao acao changed the title [WIP] fix(graphiql): duplicate query history key issue, fixes #988 fix(graphiql): duplicate query history key issue, fixes #988 Dec 1, 2019
@acao acao added the work-in-progress not ready to merge yet, PR is available for demonstration/review purposes label Dec 1, 2019
@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #1035 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   43.55%   43.55%           
=======================================
  Files          66       66           
  Lines        2994     2994           
  Branches      647      647           
=======================================
  Hits         1304     1304           
  Misses       1421     1421           
  Partials      269      269
Impacted Files Coverage Δ
packages/graphiql/src/components/QueryHistory.js 36.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216eaeb...af76ef2. Read the comment docs.

@acao acao removed the work-in-progress not ready to merge yet, PR is available for demonstration/review purposes label Dec 2, 2019
@acao acao requested a review from benjie December 2, 2019 01:58
@acao acao merged commit 69c6826 into master Dec 3, 2019
@acao acao deleted the fix/988-duplicate-query-history-key branch December 28, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React duplicate key warning in QueryHistory component since 0.16.0
1 participant