fix: initial request cache set, import tsc bugs #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
force-pushed
the
fix/initial-document-cache
branch
from
0ac8a95
to
d3b65a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 60.81% 60.87% +0.06%
==========================================
Files 75 75
Lines 3435 3433 -2
Branches 662 662
==========================================
+ Hits 2089 2090 +1
+ Misses 1208 1205 -3
Partials 138 138
Continue to review full report at Codecov.
|
- `handleDidOpenOrSaveNotification` didn't have all param types factored in, leading to retrieving textDocument.text from the wrong place - by fixing this, the cache is set properly. before, after typescript conversion, initial file cache was not set, only on a valid change would cache set - fix how imports of node modules happen so that the tsc compiler is happy - fix prepublish so that it doesnt run the whole shebang on every `yarn` or `yarn add` - add CI for
acao
force-pushed
the
fix/initial-document-cache
branch
12 times, most recently
from
255e690
to
64ef6a3
Compare
acao
force-pushed
the
fix/initial-document-cache
branch
from
64ef6a3
to
6a43646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleDidOpenOrSaveNotificationdidn't have all param types factored in, leading to retrieving textDocument.text from the wrong placeyarnoryarn add