Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type check #1374

Merged
merged 1 commit into from
Feb 25, 2020
Merged

fix: type check #1374

merged 1 commit into from
Feb 25, 2020

Conversation

Gumichocopengin8
Copy link
Contributor

I got the following errors in packages/graphql-language-service-server/src/tests/GraphQLCache-test.ts

Argument of type 'Map<unknown, unknown>' is not assignable to parameter of type 'Map<string, ObjectTypeInfo>'.
  Type 'unknown' is not assignable to type 'string'

So added types to receive benefits of typescript

@acao
Copy link
Member

acao commented Feb 25, 2020

great work! thank you

@acao acao merged commit 84cc41e into graphql:master Feb 25, 2020
@Gumichocopengin8 Gumichocopengin8 deleted the feature/type-fixes branch February 25, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acao acao acao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gumichocopengin8 @acao