-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: typescript, tsx, jsx support for LSP server using babel #1427
Conversation
691b8e3
to
a00a6fe
Compare
Does this do the same job as https://github.com/Quramy/ts-graphql-plugin? |
yes! the only difference now is that it will handle ts/tsx files when you open them. still need to get vscode workspaces configured correctly to read all the embedded graphql up front |
to add, the typescript language plugin is still valuable for a lot of cases. this just replaces the need for it in the server |
6c878d7
to
ddf88d7
Compare
ddf88d7
to
258b2e5
Compare
This looks good to me! This will allow people who want to support other languages than the mainstream ones (like ReasonML for me) to do that through replacing |
33957f8
to
fbce8a5
Compare
@zth last commit here fixes that bug i saw in discord, otherwise looks like everything is working fine! I've had some issues with setting up our example extension, but i think i understand what I'm missing after working with yours and @divyenduz 's more carefully. note: I was not able to configure your graphql + reasonml extension to work with .ts or .tsx files to test this capability end to end, despite changing the |
639be64
to
aa2985a
Compare
-tests for typecript and tsx added
getQueryAndRange
changed toparseDocument
, and made override-able asparse
bystartServer
.